[Feature Request]: Already executed and outputted part should not re-execute even when a later node is changed
Is there an existing issue for this?
- [x] I have searched the existing issues and checked the recent builds/commits
What would your feature do ?
It used to be like this: The already executed and outputted part won't re-execute if nothing is changed upto the output point even if a later node after that output is enabled or changed later. For example, if an image was generated it was possible to directly use the latent from the ksampler for later improvement without re-executing the primary generation. But now it re-executes the whole workflow. Please bring back that feature. My ComfyUI version is 0.3.38 and comfyui_frontend version is 1.20.7.
Proposed workflow
- Go to ....
- Press ....
- ...
Additional information
No response
┆Issue is synchronized with this Notion page by Unito
I cannot reproduce this at all. Are you able to share a minimal workflow that shows the issue?
You are right, not reproducible when all custom are disabled. Sorry for the confusion.
Hunted for it in my old workflow for sometime and found out that it wasn't about the second pass at all. Primary generation was re-executing even when I removed the second pass nodes that were there for modifying the primary generation. After complete simplification realized that it is only happening when two "CLIPTextEncode" nodes are converted to a group node; the problem disappears if they are converted back to separate nodes. So, I saved the simplified workflow(with the group node) and started ComfyUI with "--disable-all-custom-nodes" to see if it persists -and- it did !! Then I made that same workflow from scratch, strangely the problem disappeared. Then again restarted the server in safe mode and it disappeared completely even in the old workflow.
Now only happens when custom nodes are enabled -and- two CLIPTextEncode nodes are joined together as a group node. Must be a custom node that is causing this even when only basic comfy core nodes are in use.