ComfyUI_frontend icon indicating copy to clipboard operation
ComfyUI_frontend copied to clipboard

[Bug]: eslint coverage doesn't match tsconfig

Open benceruleanlu opened this issue 7 months ago • 0 comments

Frontend Version

1.17.0

Expected Behavior

To not receive an ESLint error when working with, during precommit, etc.

Actual Behavior

Parsing error: ESLint was configured to run on <tsconfigRootDir>/browser_tests\tests\graph.spec.ts using parserOptions.project: <tsconfigRootDir>/tsconfig.json However, that TSConfig does not include this file. Either:

  • Change ESLint's list of included files to not include this file
  • Change that TSConfig to include this file
  • Create a new TSConfig that includes this file and include it in your parserOptions.project See the typescript-eslint docs for more info: https://typescript-eslint.io/troubleshooting/typed-linting#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-fileeslint

Steps to Reproduce

npx lint-staged on staged files ending in .test.ts, .cjs, and probably more.

Debug Logs

Irrelevant

Browser Logs

Irrelevant

Setting JSON

Irrelevant

What browsers do you use to access the UI ?

No response

Other Information

eslint.config.js

export default [
  {
    files: ['src/**/*.{js,mjs,cjs,ts,vue}']
...
    languageOptions: {
...
      parserOptions: {
        project: './tsconfig.json',
...

tsconfig.json

...
  "include": [
    "src/**/*",
    "src/**/*.vue",
    "src/types/**/*.d.ts",
    "tests-ui/**/*",
    "global.d.ts"
  ]
...

┆Issue is synchronized with this Notion page by Unito

benceruleanlu avatar Apr 18 '25 01:04 benceruleanlu