ComfyUI_frontend icon indicating copy to clipboard operation
ComfyUI_frontend copied to clipboard

[Feature Request]: Remove hidden "Advanced Widgets"

Open brknsoul opened this issue 10 months ago • 9 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Node Widgets should not be hidden by default.

Proposed workflow

n/a

Additional information

No response

┆Issue is synchronized with this Notion page by Unito

brknsoul avatar Jan 13 '25 23:01 brknsoul

@pythongosssss Can you take a look at this issue?

We might want to drop the support for group node if we have subgraph planned on the horizon. In case it's too much effort to fix the group node.

huchenlei avatar Jan 14 '25 02:01 huchenlei

The issue is solved if the widget isn't hidden. If I knew the widget was there, I would have noticed the incorrect value.

It's difficult to debug something you can't see!

brknsoul avatar Jan 14 '25 02:01 brknsoul

The issue is solved if the widget isn't hidden. If I knew the widget was there, I would have noticed the incorrect value.

It's difficult to debug something you can't see!

Can you describe the issue that occurred? I don't fully understand.

christian-byrne avatar Jan 14 '25 02:01 christian-byrne

This 'feature' is really unneeded

If you think it has future applications (currently, it only exists on CLIP loaders), then make a symbol or something with tooltip to indicate there are Advanced widgets hidden.

image

An off-the-cuff suggestion: the top-left minimize button could be a tri-state toggle; fully minimized, show partial, show all. One could right-click a widget and toggle it only shown in "show all". (the nomenclature could be better lol)

brknsoul avatar Jan 14 '25 02:01 brknsoul

This 'feature' is really unneeded

This would be more useful if we could select the widgets we want to hide. We could use the right click menu for this ( like we do for converting widgets to input ).

If you think it has future applications (currently, it only exists on CLIP loaders), then make a symbol or something with tooltip to indicate there are Advanced widgets hidden.

An off-the-cuff suggestion: the top-left minimize button could be a tri-state toggle; fully minimized, show partial, show all.

I agree, we could have a tri-state button, when there are hidden widgets. And in this case, the button could be a blue "dot" ( same color as the advanced widgets border ).

JorgeR81 avatar Jan 14 '25 10:01 JorgeR81

We might want to drop the support for group node if we have subgraph planned on the horizon. In case it's too much effort to fix the group node.

I agree with this. I like the concept of group nodes, but I never used them much, because of past issues. I think having subgraphs would be better and would make group nodes mostly redundant.

JorgeR81 avatar Jan 14 '25 10:01 JorgeR81

This feature is unrelated to group nodes and was explicitly asked for by multiple developers in order to hide widgets that users should rarely need to interact with. The initial design was a tri-state indicator for it however it was deemed to be overly complex for the feature.

Edit: Here was the original prototype, icons were just for demonstration not final:

2024-03-firefox_TZGCERHJFB.webm

pythongosssss avatar Jan 14 '25 18:01 pythongosssss

Here was the original prototype, icons were just for demonstration not final:

It looks great ! I hope we can have it in the future. Or something similar.


On a side note, the cg-controller extension also allows hiding widgets, and it's really useful.

https://github.com/chrisgoringe/cg-controller

fd1

JorgeR81 avatar Jan 14 '25 19:01 JorgeR81

I like the "advanced" toggle; it allows providing a simple interface by default without having to provide "Advanced" variants of every node for all the options someone might someday want to play with.

I think even if there were an option to hide individual widgets, as a node author I'd still appreciate the ability to mark some parameters as hidden by default simply because most users won't need them and having them visible by default just increases noise.

I do agree that the toggle should be more discoverable, though, but that's just an UI issue.

asagi4 avatar Mar 03 '25 13:03 asagi4