ComfyUI-Manager icon indicating copy to clipboard operation
ComfyUI-Manager copied to clipboard

Brand New Comfy UI install - AttributeError: 'IterableList' object has no attribute 'master

Open gateway opened this issue 1 year ago • 12 comments

I just set up a brand new comfy ui portable and installed the ui manager with the batch file, it properly installed the manager but when I run update all I see this in the console...

FETCH DATA from: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json [DONE]
[ComfyUI-Manager] All startup tasks have been completed.
[ComfyUI-Manager] The ComfyRegistry cache update is still in progress, so an outdated cache is being used.
nightly_channel: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/cache
FETCH DATA from: E:\ComfyUI_windows_portable\ComfyUI\user\default\ComfyUI-Manager\cache\1514988643_custom-node-list.json [DONE]
[ComfyUI-Manager] The ComfyRegistry cache update is still in progress, so an outdated cache is being used.
nightly_channel: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/cache
FETCH DATA from: E:\ComfyUI_windows_portable\ComfyUI\user\default\ComfyUI-Manager\cache\1514988643_custom-node-list.json [DONE]
Traceback (most recent call last):
  File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\comfyui-manager\glob\manager_core.py", line 2373, in update_to_stable_comfyui
    repo.git.checkout(repo.heads.master)
                      ^^^^^^^^^^^^^^^^^
  File "E:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\git\util.py", line 1200, in __getattr__
    return list.__getattribute__(self, attr)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'IterableList' object has no attribute 'master'
ComfyUI update fail: The installed ComfyUI does not have a Git repository.
Updating: comfyui-manager
[ComfyUI-Manager] Queued works are completed.
{'update-comfyui': 1, 'update-main': 1}

After restarting ComfyUI, please refresh the browser.

I figured you would want to know..

comfy ui portable was installed by downloading the latest (i think 3.15) and I ran the nvidia gpu bat file to launch it, then I installed the manager an ran the update in the UI .. just wanted to share..

gateway avatar Feb 24 '25 09:02 gateway

Check if the path E:\ComfyUI_windows_portable\ComfyUI\.git exists.

ltdrdata avatar Feb 24 '25 11:02 ltdrdata

It's the same for me.

Traceback (most recent call last):
  File "W:\SynologyDrive\Comfy\ComfyUI\custom_nodes\comfyui-manager\glob\manager_core.py", line 2373, in update_to_stable_comfyui
    repo.git.checkout(repo.heads.master)
                      ^^^^^^^^^^^^^^^^^
  File "W:\SynologyDrive\Comfy\python_embeded\Lib\site-packages\git\util.py", line 1200, in __getattr__
    return list.__getattribute__(self, attr)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'IterableList' object has no attribute 'master'
ComfyUI update fail: The installed ComfyUI does not have a Git repository.

Neytiri7 avatar Feb 26 '25 12:02 Neytiri7

It's the same for me.

Traceback (most recent call last):
  File "W:\SynologyDrive\Comfy\ComfyUI\custom_nodes\comfyui-manager\glob\manager_core.py", line 2373, in update_to_stable_comfyui
    repo.git.checkout(repo.heads.master)
                      ^^^^^^^^^^^^^^^^^
  File "W:\SynologyDrive\Comfy\python_embeded\Lib\site-packages\git\util.py", line 1200, in __getattr__
    return list.__getattribute__(self, attr)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'IterableList' object has no attribute 'master'
ComfyUI update fail: The installed ComfyUI does not have a Git repository.

Check if the path W:\SynologyDrive\Comfy\ComfyUI\.git exists.

ltdrdata avatar Feb 26 '25 13:02 ltdrdata

It's the same for me.

Traceback (most recent call last):
  File "W:\SynologyDrive\Comfy\ComfyUI\custom_nodes\comfyui-manager\glob\manager_core.py", line 2373, in update_to_stable_comfyui
    repo.git.checkout(repo.heads.master)
                      ^^^^^^^^^^^^^^^^^
  File "W:\SynologyDrive\Comfy\python_embeded\Lib\site-packages\git\util.py", line 1200, in __getattr__
    return list.__getattribute__(self, attr)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'IterableList' object has no attribute 'master'
ComfyUI update fail: The installed ComfyUI does not have a Git repository.

Check if the path W:\SynologyDrive\Comfy\ComfyUI\.git exists.

.git folder exists in that path.

Neytiri7 avatar Feb 26 '25 13:02 Neytiri7

It's the same for me.

Traceback (most recent call last):
  File "W:\SynologyDrive\Comfy\ComfyUI\custom_nodes\comfyui-manager\glob\manager_core.py", line 2373, in update_to_stable_comfyui
    repo.git.checkout(repo.heads.master)
                      ^^^^^^^^^^^^^^^^^
  File "W:\SynologyDrive\Comfy\python_embeded\Lib\site-packages\git\util.py", line 1200, in __getattr__
    return list.__getattribute__(self, attr)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'IterableList' object has no attribute 'master'
ComfyUI update fail: The installed ComfyUI does not have a Git repository.

Check if the path W:\SynologyDrive\Comfy\ComfyUI\.git exists.

.git folder exists in that path.

Go to W:\SynologyDrive\Comfy\ComfyUI in cmd.

And execute this

git status
git branch -al

What is displayed?

ltdrdata avatar Feb 27 '25 09:02 ltdrdata

Image

W:\SynologyDrive\Comfy\ComfyUI>git status
HEAD detached at v0.3.14
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   comfy/cli_args.py
        modified:   server.py

no changes added to commit (use "git add" and/or "git commit -a")

W:\SynologyDrive\Comfy\ComfyUI>git branch -al
* (HEAD detached at v0.3.14)
  remotes/origin/HEAD -> origin/master
  remotes/origin/base-path-env-var
  remotes/origin/desktop-release-feb172025
  remotes/origin/desktop-release-feb192025
  remotes/origin/master
  remotes/origin/model-paths-helper
  remotes/origin/remove_internal_files_api
  remotes/origin/rh-docs
  remotes/origin/rh-paths
  remotes/origin/wan-model-release
  remotes/origin/webfiltered-patch-1
  remotes/origin/worksplit-multigpu

Neytiri7 avatar Feb 27 '25 09:02 Neytiri7

is this happening since its the portable downloa which isnt a full git repo, ie vs someone doing a git clone .. and not using portable?

gateway avatar Feb 27 '25 14:02 gateway

I have reinstalled it. As soon as I unpack the compressed file, I converted the branch to Master.

Then, there are no more errors. So, I installed the custom node again and finished it.

Neytiri7 avatar Feb 27 '25 19:02 Neytiri7

Based on your information, there should theoretically be no issues since the master branch already exists. However, I will conduct a reproduction test to verify.

ltdrdata avatar Feb 27 '25 23:02 ltdrdata

is this happening since its the portable downloa which isnt a full git repo, ie vs someone doing a git clone .. and not using portable?

The portable version also includes a full Git repository, so this shouldn’t be an issue. However, since there might be some edge cases, I’ll need to take a closer look.

ltdrdata avatar Feb 27 '25 23:02 ltdrdata

Update to the latest ComfyUI-Manager and test again. Error logging has been enhanced.

ltdrdata avatar Mar 02 '25 08:03 ltdrdata

Could this just be the difference between master vs main?

D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager>git status
On branch main
Your branch is up to date with 'origin/main'.
D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager>git branch -al
* main
  remotes/origin/HEAD -> origin/main
  remotes/origin/api/openapi-spec
  remotes/origin/attach_node_versions
  remotes/origin/dbg1484-1
  remotes/origin/docs/docs-readme
  remotes/origin/docs/glob-readme
  remotes/origin/docs/js-readme
  remotes/origin/docs/node-db-readme
  remotes/origin/draft-v4
  remotes/origin/draft-v4-add-legacy-route
  remotes/origin/draft-v4-contributing
  remotes/origin/draft-v4-snapshot-diff
  remotes/origin/feat/add-taskqueue-unit-tests
  remotes/origin/feat/cacheless-v2
  remotes/origin/feat/complete-todo-implementation
  remotes/origin/fix/manager-v4-uv
  remotes/origin/fix/missing-nodes-in-subgraph
  remotes/origin/main
  remotes/origin/manager-v4
  remotes/origin/readme-for-migration
  remotes/origin/refactor/pygit2
  remotes/origin/reverted-matrix-nio
  remotes/origin/rework_version_store
  remotes/origin/rh-test
  remotes/origin/rhform
  remotes/origin/tests/api-tests

Seems like master should fallback to main since this is a common refactor going forwards. glob\manager_core.py: 3375 main_branch = repo.heads.master

tomndroid avatar Oct 02 '25 05:10 tomndroid