iTop
iTop copied to clipboard
N°8921 - feat(AttributeLinkedSet): Allow for export in Spreadsheet HTML format
Base information
| Question | Answer |
|---|---|
| Related to a SourceForge thead / Another PR / Combodo ticket? | N/A |
| Type of change? | Enhancement |
Objective
Exporting a LinkedSet attribute with spreadsheet HTML just returns the list of IDs of the linked objects, which is not very helpful for further processing.
Proposed solution
- Export the friendly names for the linked objects when localised, IDs otherwise.
- Add option to display the attribute as CSV in templates.
Checklist before requesting a review
- [x] I have performed a self-review of my code
- [x] I have tested all changes I made on an iTop instance
- [ ] I have added a unit test, otherwise I have explained why I couldn't
- [x] Is the PR clear and detailed enough so anyone can understand digging in the code?
Hey @Hipska, thank you for your PR. It seems nice, but why IDs are exported when the object isn't localised ? Shouldn't it be only when there is no friendly name ? Except this small details, it has been accepted in functional review :)
This was to keep backward compatibility. If somebody relied on having the IDs, then they should still be there when using no localisation.