iTop
iTop copied to clipboard
N°8123 - Improve on mention data parsing
Base information
| Question | Answer |
|---|---|
| Related to a SourceForge thead / Another PR / Combodo ticket? | N°8123 |
| Type of change? | Enhancement |
Objective (enhancement)
Avoid using regex (or at least improve the current one) to detect pattern in HTML
Proposed solution (bug and enhancement)
Use XPath, which is more appropriate and safer than regex
Checklist before requesting a review
- [x] I have performed a self-review of my code
- [x] I have tested all changes I made on an iTop instance
- [x] I have added a unit test, otherwise I have explained why I couldn't
- [x] Is the PR clear and detailed enough so anyone can understand digging in the code?
Checklist of things to do before PR is ready to merge
- Existing unit tests are not breaking