iTop icon indicating copy to clipboard operation
iTop copied to clipboard

Feature/2535 split file

Open accognet opened this issue 4 months ago • 4 comments

Too many commits on this PR, and it's impossible to squash it without losing the Git history. Keep it for split files.

Split files : core/action.class.inc.php core/asynctask.class.inc.php core/attributedef.class.inc.php core/event.class.inc.php core/valuesetdef.class.inc.php core/event.class.inc.php

accognet avatar Aug 28 '25 09:08 accognet

Is there a particular reason why you don't move these files in the /src folder using the PSR-4 naming convention so everything is autoloded properly? (It will require to modify the code a bit to discover classes implementing/extending the base classes)

Molkobain avatar Aug 28 '25 10:08 Molkobain

I've done the first step of splitting the files. Next week, we'll discuss their final placement.

accognet avatar Aug 28 '25 12:08 accognet

Too many commits on this PR, and it's impossible to squash it without losing the Git history. Keep it for split files.

accognet avatar Sep 12 '25 14:09 accognet

Yeah, I also prefer not to use squash just for that reason; loosing history 😉

Hipska avatar Sep 15 '25 07:09 Hipska