iTop icon indicating copy to clipboard operation
iTop copied to clipboard
verified publisher icon Combodo

N°7385 - Trigger on mention executed even if it's not a mention with @

Open accognet opened this issue 1 year ago • 2 comments

Internal

accognet avatar Mar 22 '24 10:03 accognet

I'm moving this PR to "Functional review" even though the technical one didn't occur yet, so the important point can be discussed before going any further.

Molkobain avatar Jul 10 '24 07:07 Molkobain

Functional review:

  • Expected behavior: Only trigger a mention, if the hyperlink starts with the corresponding marker (e.g. @ for Person)
  • Target version: 3.2.x if code changes are not too risky, 3.3.0 otherwise. Will be determined, once PR is corrected

Molkobain avatar Aug 13 '24 14:08 Molkobain

Code review : the preceding character must be dehardcoded from '@' to the one given in the configuration, depending on the object class. Also consider a multi-byte safe function.

rquetiez avatar Jan 28 '25 14:01 rquetiez