Combodo
N°3213 - Add the possibility to manage the attributs' prompt order during a transition
Transition screen before setting
Add this settings in xml file :
Transition screen after setting:
The fields which should be displayed but which are not in the presentation config are added after. If you add a field that should not be displayed, it is not displayed. Ex:
-> No modification of the display, the agent does not appear
@accognet as this bug was planned on iTop 3.x I'm assuming that it is not a development for the upcoming 3.1, is it a proposition that you want to pitch during the PRs review?
Discussed during technical review: Good PR but we need to discuss more deeply within the R&D team and with the Product team:
- Where to put the XML definition of this.
- How to make transition forms display as expected most of the time (ordered as the "details" zlist instead of ordered by dependencies) without forcing people to declare a zlist for a transition.
This will be discussed next week during functional review.
Functional review :
Only one zlist for all transitions ? Simpler, yes do it ! But don't forget the fallback for forgotten fields (not defined in XML but present in the transition anyway) What name for the XML node ? To be discussed with Romain + Vincent (we might add a possibility to specify each transition in the future, but a transition is defined both by the stimulus and the target state)
In the meantime, implement the fallback : return the order similar to the one defined in the details zlist. This will be the new default behavior, product team is OK to change it in 3.1 (major release + nobody likes the current one)
Note that in the portal we already have one form per stimulus (see forms/form/modes/mode apply_stimulus) Also note that there is an ongoing bug on n-n relations in transition forms (not enough width for now)
Discussed during technical review:
- Code needs to be simplified / commented
- Attributes list / ordering has to be extracted in a dedicated method so we can add a unit test to it. Moreover, this will be discussed with the product team as the specifications / use cases do not seem to be clear for everyone.
Accepted during Functional Review. Warning : the current screenshot of a transition with the fix isn't up to date !
Anne Catherine did some changes to handle Guillaume feedbacks, they need to be reviewed technically. Also we need to figure out how to add an automatic test.