sqlalchemy-jsonapi icon indicating copy to clipboard operation
sqlalchemy-jsonapi copied to clipboard

Incomplete support for SQLAlchemy types

Open jimbobhickville opened this issue 9 years ago • 5 comments

Running into this error with a postgres numeric type which leverages decimal.Decimal under the hood:

TypeError: Decimal('1.6') is not JSON serializable

I think I see how to add it, so I'll put up a PR if I'm successful.

jimbobhickville avatar Aug 20 '16 15:08 jimbobhickville

So I have a fix, but I had to go back a dozen commits or so to find a commit that wasn't broken to branch from. Any chance you can put the unfinished stuff into a separate branch and get master back in a clean state so I can submit a proper PR and get this fix released?

jimbobhickville avatar Aug 20 '16 22:08 jimbobhickville

I just branched the 4.x.x branch off so you can submit the fix to there.

ColtonProvias avatar Aug 23 '16 19:08 ColtonProvias

Thanks, I'll update my branch and get a PR up later tonight.

jimbobhickville avatar Aug 23 '16 20:08 jimbobhickville

Ok, it ended up being a few days before I could get to it, but PR is up now.

jimbobhickville avatar Aug 27 '16 18:08 jimbobhickville

I have a similar issue with Data type. any advice on how to handle that, please?

vilka95 avatar Nov 17 '17 21:11 vilka95