ColtonIdle

Results 90 comments of ColtonIdle

It looks like everything boils down to a bunch of activities that are added to my AndroidManifest? BUT I did try the tools node remove trick to get rid of...

I moved to just using implementation("com.stripe:payments-core:20.9.0") implementation("com.stripe:payments-model:20.9.0") implementation("com.stripe:stripe-core:20.9.0") instead of implementation("com.stripe:stripe-android:20.9.0") and now instead of 4.9MB taken up by stripe, there is only 2.6MB, but when my app is 4.3...

We use these imports for just adding and removing cards in our app. Our backend actually does the charging and everything import com.stripe.android.Stripe import com.stripe.android.core.StripeError import com.stripe.android.CustomerSession import com.stripe.android.createPaymentMethod import...

but yeah. let me know if you want me to help test in anything related to shrinking the size. even if there are proguard rules. im more than happy to...

AWESOME. I didn't know if safe to remove because (for example) i didn't know if I built my own add credit card flow, if certain cards would require additional verification...

Oh interesting. Okay. I was just about to come here and ask "Are you sure I can't get rid of" "com.stripe.android.view.AddPaymentMethodActivity" "com.stripe.android.view.PaymentMethodsActivity" "com.stripe.android.view.PaymentFlowActivity" "com.stripe.android.view.PaymentAuthWebViewActivity" "com.stripe.android.view.PaymentRelayActivity" "com.stripe.android.payments.StripeBrowserLauncherActivity" "com.stripe.android.payments.StripeBrowserProxyReturnActivity" "com.stripe.android.payments.core.authentication.threeds2.Stripe3ds2TransactionActivity" "com.stripe.android.googlepaylauncher.StripeGooglePayActivity" "com.stripe.android.googlepaylauncher.GooglePayLauncherActivity"...

Not really relevant, butinteresting that ChallengeActivity doesn't allow itself to be removed

Hm. Can't remove two of the activities ``` /Users/cidle/dev/rollertoaster/app/src/main/AndroidManifest.xml:39: Error: AddPaymentMethodActivity must extend android.app.Activity [Instantiatable] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/cidle/dev/rollertoaster/app/src/main/AndroidManifest.xml:41: Error: PaymentFlowActivity must extend android.app.Activity [Instantiatable] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Explanation for issues of type "Instantiatable":...

After removing all of the other activities except for those 2 above, there was no change in apk size 😦 More than happy to test any new dependencies you come...

Awesome. Looking forward to lowering my apk size!