PetaPoco icon indicating copy to clipboard operation
PetaPoco copied to clipboard

Published 20 hours ago • verified publisher icon CollaboratingPlatypus

Non parameterized queries can cause high memory usage

Open Shazwazza opened this issue 11 years ago • 3 comments

I've put all the details in a PR for NPoco here:

https://github.com/schotime/NPoco/pull/134

But decided it might be best to log an issue on this original project for completeness.

Shazwazza avatar Sep 25 '14 08:09 Shazwazza

I would love this as a PR for PetaPoco. Would you have time?

We're looking for people #204.

pleb avatar Dec 05 '15 09:12 pleb

My original PR was pulled in and fixed in NPoco (as above link) and then enhanced so would need to look at how it's done there. Also note, this is the original blog post I wrote about this: http://shazwazza.com/post/petapoco-can-cause-high-memory-usage-with-certain-queries/

Have you already approached NPoco about collaboration? The project has moved way further ahead and it would be ideal to not have more than 2 different products based on the same core. They've also implemented all of the code to run on .Net CoreCLR.

Shazwazza avatar Dec 14 '15 10:12 Shazwazza

I've reached out a few times with limited response. Given that I don't simply want to take the NPoco code without permission, the only choice is to forge ahead. CoreCLR is planned. However, I want to finish the integration tests and clean up before I implement it.

pleb avatar Dec 14 '15 12:12 pleb