online icon indicating copy to clipboard operation
online copied to clipboard

calc: add support for .uno:ConvertFormulaToValue command

Open rparth07 opened this issue 1 year ago • 5 comments

Change-Id: Ia2f48eca778c396ae1fa17afe2d92d9631aadad5

  • Resolves: #7984
  • Target version: master

Summary

  • Added support to replace a formula with its value in Data > Formula to Value
  • Here, is the LOKit patch for the same: https://gerrit.libreoffice.org/c/core/+/168387

Checklist

  • [X] Code is properly formatted
  • [X] All commits have Change-Id
  • [ ] I have run tests with make check
  • [ ] I have issued make run and manually verified that everything looks okay
  • [X] Documentation (manuals or wiki) has been updated or is not required

rparth07 avatar May 31 '24 16:05 rparth07

shouldn't there be LOKit patch to enable the command status?

hfiguiere avatar May 31 '24 17:05 hfiguiere

shouldn't there be LOKit patch to enable the command status?

Do you have any reference on how to enable command status using LOKit patch? I'm not much aware about it.

rparth07 avatar May 31 '24 18:05 rparth07

shouldn't there be LOKit patch to enable the command status?

Do you have any reference on how to enable command status using LOKit patch? I'm not much aware about it.

After conducting some research, I discovered the following approach: https://gerrit.libreoffice.org/c/core/+/132585

To enable the command, it appears that I need to modify two files in the core:

  1. desktop/source/lib/init.cxx
  2. sfx2/source/control/unoctitm.cxx

Could you please confirm if this is the correct way?

rparth07 avatar May 31 '24 19:05 rparth07

@eszkadev and @pedropintosilva would love to hear your thoughs on this.

rparth07 avatar Jun 03 '24 17:06 rparth07

here, is the LOKit patch to enable the uno command: https://gerrit.libreoffice.org/c/core/+/168387

rparth07 avatar Jun 03 '24 17:06 rparth07

hello @rparth07 i just encounter the same thing you are having.And thanks to @eszkadev i solved it :)

Follow these steps.

Remove your hard coded change in unocommand.js then run scripts/unocommands.py --update /path/to/online /path/to/loffice

This will simply fix your issue.

  • Please close your CORE pr as it will be not need now after above steps.

Thanks 🙇🏼

Darshan-upadhyay1110 avatar Jul 01 '24 08:07 Darshan-upadhyay1110

@rparth07 Please rebase this PR. CC: @pedropintosilva

Darshan-upadhyay1110 avatar Aug 08 '24 09:08 Darshan-upadhyay1110

@rparth07 Please rebase this PR. CC: @pedropintosilva

Rebased :)

rparth07 avatar Aug 09 '24 16:08 rparth07