online icon indicating copy to clipboard operation
online copied to clipboard

Impress: Allow to autostart in presenation mode

Open meven opened this issue 1 year ago • 1 comments

This is implemented in two cases:

  • using a request parameter '&startPresentation=true'
    • for ppsx/pps for which the backend sends a startPresentation stateChange event. This can be overridden passing '&startPresentation=false' to allow editing the file.

The presentation can only start in present-in-window mode due to browser gating fullscreen by user activation.

Refactor SlideShow._onFullScreen to better handle the requestFullscreen permission restriction failing case. Also clean up old references to old restricted implementations.

Change-Id: I98fcb1a7da170fa1c6a7de75c680259163233c9d

Better used with https://gerrit.libreoffice.org/c/core/+/163652

  • Resolves: #
  • Target version: master

Summary

TODO

  • [ ] ...

Checklist

  • [ ] Code is properly formatted
  • [ ] All commits have Change-Id
  • [ ] I have run tests with make check
  • [ ] I have issued make run and manually verified that everything looks okay
  • [ ] Documentation (manuals or wiki) has been updated or is not required

meven avatar Feb 20 '24 12:02 meven

I see the gerrit review is for 24.04, are we targetting this for 24.04 only?

hfiguiere avatar Feb 23 '24 17:02 hfiguiere

I see the gerrit review is for 24.04, are we targeting this for 24.04 only?

Yes, I mean to target the new version, this is a new feature. We can backport, but I'd rather not.

meven avatar Feb 26 '24 08:02 meven

'nit: one of the commit has a typo (as reflected in the PR title)

hfiguiere avatar Feb 26 '24 14:02 hfiguiere

There should also be a SDK documentation update to document how this works.

hfiguiere avatar Feb 26 '24 16:02 hfiguiere

There should also be a SDK documentation update to document how this works.

I am trying to find a place to document this, there does not seem to be a prefect place at the moment.

Other url query parameters such as closebutton, revisionhistory, randomUser, darkTheme, userinterfacemode, lang, dir, target, alwaysactive, permission, debug and timestamp seem to be not documented.

I think we can add a new page for those parameters, perhaps under "Get Started" > "Advanced integration".

meven avatar Feb 27 '24 09:02 meven

There should also be a SDK documentation update to document how this works.

I am trying to find a place to document this, there does not seem to be a prefect place at the moment.

Other url query parameters such as closebutton, revisionhistory, randomUser, darkTheme, userinterfacemode, lang, dir, target, alwaysactive, permission, debug and timestamp seem to be not documented.

I think we can add a new page for those parameters, perhaps under "Get Started" > "Advanced integration".

There should also be a SDK documentation update to document how this works.

I am trying to find a place to document this, there does not seem to be a prefect place at the moment.

Other url query parameters such as closebutton, revisionhistory, randomUser, darkTheme, userinterfacemode, lang, dir, target, alwaysactive, permission, debug and timestamp seem to be not documented.

I think we can add a new page for those parameters, perhaps under "Get Started" > "Advanced integration".

I created an issue in the documentation gitlab: https://gitlab.collabora.com/productivity/sdk/-/issues/2

meven avatar Feb 28 '24 08:02 meven

The core side enabling this (https://gerrit.libreoffice.org/c/core/+/163652/10) was merged.

meven avatar Mar 14 '24 08:03 meven

@pedropintosilva would you be interested in reviewing this (after Hubert) ?

meven avatar Mar 14 '24 15:03 meven