fix(helm): aliases is an regex
Summary
Checklist
- [x] Code is properly formatted
- [x] All commits have Change-Id
- [x] Documentation (manuals or wiki) has been updated or is not required
Hi @genofire! I hope you're doing well. I noticed @Rash419 has suggested a few small changes on the patch. Could you kindly take a look at them when you have a moment? It would be wonderful to get this patch into master as soon as possible. Thanks a ton! 😊
@genofire The output of aliasgroup for this patch using helm chart would be:
collabora:
aliasgroups:
- host: "http://192.168.1.201:8080"
aliases:
- "http://test.integrator1.com:443"
- "http://test.integrator2.com:443"
- "http://test.integrator3.com:443"
aliasgroup1: http://192.168.1.201:8080|http://test.integrator1.com:443|http://test.integrator2.com:443|http://test.integr
ator3.com:443`
Which is not a correct way to passing the aliases is https://sdk.collaboraonline.com/docs/installation/CODE_Docker_image.html#how-to-configure-docker-image
The output should be
aliasgroup1: http://192.168.1.201:8080,http://test.integrator1.com:443,http://test.integrator2.com:443,http://test.integr
ator3.com:443
I am not sure what this patch is trying to achieve
hmm, maybe i have not try it with protocol:// on aliases.
so an example like on @Rash419 does not work on my privat setup.
lets me try it that way.
PS on the Docu is still the example:
https://<domain1>:443,https://<your-dot-escaped-aliasname1>|<your-dot-escaped-aliasname2>:443
there is an | inside
@Rash419 what should we do with this PR?