online icon indicating copy to clipboard operation
online copied to clipboard

fix(helm): fix haproxy balance (no not use post body for balancing - just WOPISrc)

Open genofire opened this issue 2 years ago • 2 comments

This PR correct the documentation for kubernetes (helm) of the issue #7654 (i do not know where to fix the official documentation: https://sdk.collaboraonline.com/docs/installation/Proxy_settings.html#example-with-haproxy)

Ping @Rash419 and @mmeeks

Checklist

  • [x] Code is properly formatted
  • [x] All commits have Change-Id
  • [ ] Documentation (manuals or wiki) has been updated or is not required

genofire avatar Nov 13 '23 13:11 genofire

its not clear to me, why would removing check_post fix the problem ? from the documentation: If the modifier "check_post" is used, then an HTTP POST request entity will be searched for the parameter argument, when it is not found in a query string after a question mark ('?') in the URL. The message body will only start to be analyzed once either the advertised amount of data has been received or the request buffer is full. In the unlikely event that chunked encoding is used, only the first chunk is scanned. Parameter values separated by a chunk boundary, may be randomly balanced if at all. This keyword used to support an optional <max_wait> parameter which is now ignored. I interpret it as when there is check_post it also checks for POST requests https://cbonte.github.io/haproxy-dconv/1.8/configuration.html#4.2-balance%20url_param

Rash419 avatar Nov 20 '23 06:11 Rash419

@Rash419 let is discuss it in the issue #7654

genofire avatar Nov 20 '23 10:11 genofire