online icon indicating copy to clipboard operation
online copied to clipboard

Insert new slide to specific position

Open GulsahKose opened this issue 2 years ago • 2 comments

When we insert a new slide via context menu of the slidesorter, new slide should be inserted on pointer position instead of end of the last selected slide.

Change-Id: Ie5efb78d6b6ee468cda150cc416cbd2ab536d6dd

  • Resolves: #
  • Target version: master

Summary

TODO

  • [ ] ...

Checklist

  • [ ] Code is properly formatted
  • [ ] All commits have Change-Id
  • [ ] I have run tests with make check
  • [ ] I have issued make run and manually verified that everything looks okay
  • [ ] Documentation (manuals or wiki) has been updated or is not required

GulsahKose avatar Jun 23 '23 21:06 GulsahKose

Here is the followup core patch https://gerrit.libreoffice.org/c/core/+/153539

GulsahKose avatar Jun 23 '23 21:06 GulsahKose

@GulsahKose didn't this got already merged?

pedropintosilva avatar Apr 15 '24 08:04 pedropintosilva

@GulsahKose can we rebase this PR, seems to be useful

eszkadev avatar Jul 11 '24 09:07 eszkadev

Just rebased the patch, I'm working on...

GulsahKose avatar Aug 12 '24 14:08 GulsahKose

This patch is ready to review. Related core patch is here: https://gerrit.libreoffice.org/c/core/+/172113

GulsahKose avatar Aug 20 '24 12:08 GulsahKose

works good in general, but I found corner case: impress-2024-08-22_08.58.14.webm

eszkadev avatar Aug 22 '24 06:08 eszkadev

@eszkadev It should be fixed now.

GulsahKose avatar Aug 28 '24 11:08 GulsahKose