online icon indicating copy to clipboard operation
online copied to clipboard

Published 20 hours ago • verified publisher icon CollaboraOnline

fix(remote_config_pull): nullpointer if host not defined in json

Open genofire opened this issue 3 years ago • 1 comments
trafficstars

Change-Id: 206e9e3ff1fa33f2073e12fc5adf1ef0bb14d61a

Signed-off-by: genofire [email protected]

  • Resolves: #5235
  • Target version: master

Summary

Maybe fix Null-Pointer. Suggestion: drop fetchWopiHostPatterns, it is undocumented and not needed.

TODO

  • [ ] drop fetchWopiHostPatterns

Checklist

  • [ ] Code is properly formatted
  • [x] All commits have Change-Id
  • [ ] I have run tests with make check
  • [ ] I have issued make run and manually verified that everything looks okay
  • [ ] Documentation (manuals or wiki) has been updated or is not required

genofire avatar Sep 10 '22 11:09 genofire

@Ashod do you review?

genofire avatar Sep 13 '22 05:09 genofire

@mmeeks do you review?

genofire avatar Oct 05 '22 22:10 genofire

@Rash419, can you please review?

thebearon avatar Oct 10 '22 01:10 thebearon

@thebearon @genofire I have PR that drops the method and some clean ups https://github.com/CollaboraOnline/online/pull/5313

Rash419 avatar Oct 10 '22 07:10 Rash419

Sorry - many of us have been out at our annual conference - hence the delay.

mmeeks avatar Oct 10 '22 08:10 mmeeks

Hmm @Rash419 PR looks really, like it solve it either ;)

genofire avatar Oct 10 '22 17:10 genofire

https://github.com/CollaboraOnline/online/pull/5313 is merged. Closing this PR

Rash419 avatar Oct 12 '22 17:10 Rash419