online icon indicating copy to clipboard operation
online copied to clipboard

Published 20 hours ago • verified publisher icon CollaboraOnline

Handle the callback for missing fonts

Open tml1024 opened this issue 2 years ago • 3 comments

For now, just display it using an infobar. UI experts, feel free to design something more appropriate.

Signed-off-by: Tor Lillqvist [email protected] Change-Id: I0b6e592a51441299cc08d0e42ba3b5c5087b30db

  • Resolves: #
  • Target version: master

Summary

TODO

  • [ ] ...

Checklist

  • [ ] Code is properly formatted
  • [ ] All commits have Change-Id
  • [ ] I have run tests with make check
  • [ ] I have issued make run and manually verified that everything looks okay
  • [ ] Documentation (manuals or wiki) has been updated or is not required

tml1024 avatar Aug 25 '22 12:08 tml1024

@kendy , the corresponding pieces in core are: https://gerrit.libreoffice.org/c/core/+/138802 (master) and https://gerrit.libreoffice.org/c/core/+/138766 (co-22.05).

tml1024 avatar Aug 30 '22 06:08 tml1024

Core piece is now merged also in co-22.05.

tml1024 avatar Sep 07 '22 05:09 tml1024

Thank you @tml1024 let me paste here the screenshot relative to this change Screen Shot 2022-09-07 at 13 37 29

I was thinking that maybe using snackbar would be better :

Snackbar without action Snack with action
Screen Shot 2022-09-07 at 13 35 32 Screen Shot 2022-09-07 at 13 34 24

but infobar does seem to be better, specially when we don't know how many fonts will be missing. So it handles that without being a massive popup: Screen Shot 2022-09-07 at 13 38 44

pedropintosilva avatar Sep 07 '22 11:09 pedropintosilva