online icon indicating copy to clipboard operation
online copied to clipboard

Published 20 hours ago • verified publisher icon CollaboraOnline

Improve the scrollbars

Open Minion3665 opened this issue 2 years ago • 2 comments

  • Draw the railway for vertical and horizontal scrollbars
    • The railway should be 50% transparent on all apps, except for calc which should have a fully opaque railway

Signed-off-by: Skyler Grey [email protected] Change-Id: I57975e52700f3b91782f9be40ad9864fc8c3baf2

  • Target version: master

TODO

  • [x] Display railways
  • [ ] ~~Make thumbs thinner when the scrollbar is not being used~~
  • [ ] ~~(possibly) Make the trail thinner when the scrollbar is not being used~~
  • [x] (possibly) Make the scrollbars attach to the side of the window (particularly in calc where a small part of the spreadsheet displays past the scrollbar railway)
  • [x] Make the scrollbar railway have lower opacity on apps other than calc
  • [ ] ~~Fix the animating scrollbar resizing~~
  • [ ] ~~Don't let the railway overflow the bounds (i.e. clip onto the column/row headers in calc)~~
  • [ ] ~~Rewrite the writer/scrolling_spec cypress test~~ [Does not appear to be needed anymore]
  • [ ] ~~Write new cypress tests for scrollbars (copy writer test over to calc to check the scrollbar is opaque etc.)~~

Note: Crossed out tasks were planned but have (on request) been moved to be in a later PR [not yet opened]

Checklist

  • [x] Code is properly formatted
  • [x] All commits have Change-Id
  • [ ] I have run tests with make check
  • [ ] I have issued make run and manually verified that everything looks okay
  • [x] Documentation (manuals or wiki) has been updated or is not required

Minion3665 avatar Aug 10 '22 09:08 Minion3665

~~The failing test is one to test the scrollbars, so the reason it fails is fairly obvious. This test will need to be rewritten along with this PR~~ image

This test no longer fails

Minion3665 avatar Aug 10 '22 11:08 Minion3665

@pedropintosilva

Minion3665 avatar Aug 11 '22 11:08 Minion3665

@pedropintosilva the CI timed out, can you restart it please?

Minion3665 avatar Aug 16 '22 15:08 Minion3665

It seems Cypress has timed out on the CI side. I have re-triggered it.

pedropintosilva avatar Aug 17 '22 06:08 pedropintosilva

@pedropintosilva the CI timed out, can you restart it please?

I have just noticed this ^ after commenting :p , sure

pedropintosilva avatar Aug 17 '22 06:08 pedropintosilva

cypress test destkop/calc/scrolling_spec.js has to be checked and adjusted

eszkadev avatar Aug 17 '22 07:08 eszkadev

Makes sense ^ now that we have changed offsets and change scrollbars on calc to start to be drawn after the cells all those cypress coordinates are probably wrong

pedropintosilva avatar Aug 17 '22 08:08 pedropintosilva