replaced magic numbers :D

[Rimuruweeb]

• Resolves: #
• Target version: master

Summary

on line 603 couldn't replace 99 , idk was giving some error , i checked every number tho :P.

[welcome[bot]]

Thanks for opening this pull request!

Things that will help get your PR across the finish line:

• Check out our contributing guidelines.
• Connect with us through one of our communication channels.
• Click on the details link next to the failing CI checks, if any, to see an explanation on how to fix it.
• Feel free to ping @pedropintosilva or the mentor of the easyHack you are solving if you need help.

[Rimuruweeb]

https://github.com/CollaboraOnline/online/issues/4929 issue link

[Rash419]

@Rimuruweeb thanks for the PR DCO and Change-Id checks are failing if you click on the details you will find out what is the problem commit message should be meaningfull checkout this guide for more info: https://www.freecodecamp.org/news/writing-good-commit-messages-a-practical-guide/ next time you want to update the patch use --amend: https://www.atlassian.com/git/tutorials/rewriting-history

[pedropintosilva]

Thanks and welcome @Rimuruweeb ! As @Rash419 already pointed out you need to: Obtain Change-Id in commit message :

cp .git-hooks/commit-msg .git/hooks/commit-msg

And then amend your commit message and sign it off (so DCO does not complain):

git commit --amend --signoff
git push -f 

[pedropintosilva]

@Rimuruweeb did you encounter any further problem? How can I help you?

[eszkadev]

@Rimuruweeb hi, you need a ChangeId in your commit message, after you did a setup mentioned by @pedropintosilva , please do git commit --amend so it will add ChangeId

[gokaysatir]

Hello, is this PR fine now? Can we rebase and review again? Looks like a good improvement :)

[eszkadev]

Hello, is this PR fine now? Can we rebase and review again? Looks like a good improvement :)

No, it uses incorrect values currently.

[eszkadev]

Issue fixed with other commit.