The button text not visible

[snetAT]

Describe the bug The button text not visible

To Reproduce Steps to reproduce the behavior:

1. Activate in Personal - Settings Accessibility - Dark Theme
2. Set true "Use theme from the integrator" in coolwsd.xml
3. Open a document and navigate to the view menu for example, and activate "toogle ruler" or other buttons that snap to it.
4. See error

Expected behavior The button text should be visible.

Screenshots

Client details:

• OS: Linux, Windows
• Browser Chrome / Firefox
• Version 23.03
• Device: Desktop

Server details

Operating system: Linux

Web server: Apache

Database: MySQL

PHP version: 8.0 fpm

Nextcloud version: 23.03

Version of the richdocuments app latest

Version of Collabora Online 21.11.3.6

[Andreas-Kainz]

Look like it's a NextCloud Office branding.css issue.

[Ornanovitch]

I have the same problem with nextcloud dark mode. The bg color is tanken from inline css:

:root {
  ...
  --co-primary-light
  ...
}

But folks from nextcloud office told it was a COOL issue :

• https://github.com/nextcloud/richdocuments/issues/2140+

[Ezinnem]

@eszkadev, @pedropintosilva

[timar]

See also #4382

[pedropintosilva]

@snetat I think this has been fixed, in this example I have set also a dark color from within NC settings(see the active tab label) :

[pedropintosilva]

^ tested on master and distro/collabora/co-21-11

[Ornanovitch]

Just upgraded to the latest release (21.11.4.2) and it didn't fix it :/ Is it necessary to clear some cache on the NC level?

[janilowski]

The issue seems to persist on NC 24.0.2 and office 6.1.1 :p

Users of my instance also reported missing icons in this Calc menu, which is used to format cell borders. Not sure if this issue is related though, it persists without "Dark Mode" enabled.

[Ornanovitch]

Still an issue on 22.05. How can we progress on the "is it a NC or a CODE issue" question?

[jancborchardt]

Yep, happening again as mentioned in the meeting. @pedropintosilva @juliushaertl where do we fix it? :)

[juliusknorr]

So the tricky bit is that we currently read out the css variables which we do only have available for either light or dark theme, so maybe we need to add some extra backend logic to expose the light colors for Collabora. For 25 we could make use of https://github.com/nextcloud/server/pull/33564 for that easily

[juliusknorr]

Relevant code bits are in https://github.com/nextcloud/richdocuments/blob/2c61f2eadd51653c778d866b1740aac43ae9c9ac/src/helpers/coolParameters.js#L47-L79

[Ornanovitch]

Resolved by @juliushaertl : https://github.com/nextcloud/richdocuments/pull/2550 :partying_face:

[janilowski]

Resolved by @juliushaertl : nextcloud/richdocuments#2550 partying_face

This has not been fully fixed, some icons are still missing

[Ornanovitch]

I'm not sure this is the same bug...

[juliusknorr]

I cannot reproduce this with the latest release, so maybe you can try to upgrade to the latest CODE build and report a separate issue if it still occurs.

[Andreas-Kainz]

There are plenty of DarkMode issues (papercuts). For better tracking it would be better to have for each DarkMode papercut a separate issue please.