online icon indicating copy to clipboard operation
online copied to clipboard

Calc Sidebar: Fix oversized and misaligned text orientation buttons

Open algowizzz opened this issue 1 month ago • 3 comments

  • Resolves: #
  • Target version: master

Summary

Fixes the oversized and misaligned text-orientation buttons in the Calc sidebar. These buttons inherited large padding from the generic .ui-toggle button style, making them appear too large and misaligned above the label.

A targeted CSS override was added for .sidebar .jsdialog.ui-alignment .ui-togglebutton.loOrientationBtn button to reduce padding, enforce a 26×26px minimum size, align icons properly, and improve spacing.

This restores correct visual alignment and consistency with other sidebar controls. UI-only fix; no functional behavior changed.

TODO

  • [ ] ...

Checklist

  • [ ] I have run make prettier-write and formatted the code.
  • [ ] All commits have Change-Id
  • [ ] I have run tests with make check
  • [ ] I have issued make run and manually verified that everything looks okay
  • [ ] Documentation (manuals or wiki) has been updated or is not required

algowizzz avatar Nov 21 '25 11:11 algowizzz

thanks @algowizzz ! But please after looking your PR please do sign- off your commits and Add Change -id.

Sign-off (DCO)

You should only do this if:

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line. In your local branch, run: git rebase HEAD~1 --signoff Force push your changes to overwrite the branch: git push --force-with-lease origin Switch-between-spreadsheet-tabs Change-id How to obtain Change-Id in commit message :

copy commit hook : cp .git-hooks/commit-msg .git/hooks/commit-msg

And then amend your commit message : git commit --amend git push -f

Darshan-upadhyay1110 avatar Nov 30 '25 13:11 Darshan-upadhyay1110

@algowizzz is this for fixing https://github.com/CollaboraOnline/online/issues/13486

cc @Darshan-upadhyay1110

banobepascal avatar Dec 01 '25 20:12 banobepascal

Hi @banobepascal, thanks for reviewing the PR 🙂

@algowizzz is this related to https://github.com/CollaboraOnline/online/issues/13486 ? If so, it seems two developers might be working on the same issue.

Please check the discussion in that issue — I’ve already assigned it to another community developer. For future reference, kindly pick issues that are unassigned, or ask in the thread so we can assign them properly. It helps us keep everything organized.

Darshan-upadhyay1110 avatar Dec 02 '25 04:12 Darshan-upadhyay1110