online icon indicating copy to clipboard operation
online copied to clipboard
verified publisher icon CollaboraOnline

iconview: enhanced CSS for presets and shadows layout and adjusted icon view entry alignment

Open rparth07 opened this issue 6 months ago • 5 comments

Change-Id: Ic79f0a5f179dde21cdd15dbf6d0e79b9c8bf3e6b

This PR is part of icon-view conversion. Related patch: https://gerrit.libreoffice.org/c/core/+/186326

Target:

  1. Format->Format Page->Borders->Presets
  2. Format->Format Page->Borders->Position
  3. other icon view entries

Checklist

  • [ ] I have run make prettier-write and formatted the code.
  • [ ] All commits have Change-Id
  • [ ] I have run tests with make check
  • [ ] I have issued make run and manually verified that everything looks okay
  • [ ] Documentation (manuals or wiki) has been updated or is not required

rparth07 avatar Jun 10 '25 10:06 rparth07

@rparth07 Could you please add a description to this PR and maybe screenshots of before and after? It helps provide context and makes it easier to reference later on. Thanks!

banobepascal avatar Jun 11 '25 23:06 banobepascal

@rparth07 Could you please add a description to this PR and maybe screenshots of before and after? It helps provide context and makes it easier to reference later on. Thanks!

or cypress visual test :)

eszkadev avatar Jun 12 '25 06:06 eszkadev

@rparth07 Could you please add a description to this PR and maybe screenshots of before and after? It helps provide context and makes it easier to reference later on. Thanks!

Here are updated icon view entries: Top images i.e. layouts and transition are from dark mode. image

rparth07 avatar Jun 18 '25 10:06 rparth07

@rparth07 Could you please add a description to this PR and maybe screenshots of before and after? It helps provide context and makes it easier to reference later on. Thanks!

or cypress visual test :)

I guess this PR only contains minor CSS fixes needed after icon view conversion and don't require cypress visual test. I have also added screenshot above. Let me know if you think otherwise. Thanks :)

rparth07 avatar Jun 18 '25 10:06 rparth07

There is a dark blue border on active shadow-images in Position instead of gray

Screencast from 18-06-25 16:25:56.webm

banobepascal avatar Jun 18 '25 13:06 banobepascal

There is a dark blue border on active shadow-images in Position instead of gray Screencast.from.18-06-25.16.25.56.webm

@banobepascal could you check with the core patch applied? your screenshot shows "ValueSet" which is single image, with core patch you will get "IconView" with image/per item

eszkadev avatar Jun 23 '25 04:06 eszkadev

I also removed unnecessary margin to remove unwanted scrollbar for slide transition. image

rparth07 avatar Jun 25 '25 07:06 rparth07