online icon indicating copy to clipboard operation
online copied to clipboard

AdminIntegratorSettings: move new accessibility toggle

Open pedropintosilva opened this issue 6 months ago • 1 comments

Describe the Bug

(Thanks @timar for reporting it)

Introduce by @caolanm in

  • fa89742f3cc6730353c0f46b1a5fdbf39441e55a
  • show warning for accessibility view settting if server a11y is off

See bellow how it looks in richdocuments (but it's true for any integrator, since we are talking about an iframe)

Actual Behavior

Image

Expected Behavior

  • The setting should be moved to one of the other group settings and not be a new group.
    • I suggest to move it inside of Document Settings underAdjust how office documents behave. because this toggle is only referent to the document (screen reader always work for the surrounding UI independent of the toggle's state). Alternatively, it could be added inside of Interface (bellow the subtitle and above the browser settings) but, as state before it seems misleading.
  • No need to have all that HTML structure (fieldset with option label), it's enough to have a checkbox with a label

Related files:

  • browser/admin/src/integrator/AdminIntegratorSettings.ts
  • /browser/admin/adminIntegratorSettings.html

pedropintosilva avatar May 29 '25 13:05 pedropintosilva

The document settings affect the document itself, so those are applied when the document is opened by the initial user and affect all users that join the document. So I'd prefer to not have it in there.

This "viewsetting" thing affects the individual user, so it's closer to "Interface" than "Document" But there was a desire to separate it from the Interface "browser settings" which are things the user can toggle on and off in the typical online UI. While this "viewsetting" can't be overriden from the typical UI

caolanm avatar May 29 '25 14:05 caolanm

I understand, so let's move into the Interface Settings (AKA browsersettings) UI section and restructure it to

  • [Checkbox] In-document Screen Reader
  • Warning should be moved to a <label> underneath

Not: please drop the visible fieldset (outline)

This way we make it more specific and easier to understand

pedropintosilva avatar Sep 10 '25 10:09 pedropintosilva