online icon indicating copy to clipboard operation
online copied to clipboard
verified publisher icon CollaboraOnline

Presenter Console

Open hcvcastro opened this issue 1 year ago • 2 comments

  • browser: slideshow: simplify notify blocked popup
  • browser: slideshow: simplify 'onSlideShowInfo'
  • browser: slideshow: add options parameter to SlideShowPresenter
  • browser: slideshow: add options parameters to not start presentation
  • browser: slideshow: change to public '_startSlide' access
  • browser: slideshow: add 'PresenterConsole' class
  • browser: slideshow: avoid unhandled excpetions requestedSlideHash

hcvcastro avatar Sep 24 '24 14:09 hcvcastro

I hacked a bit current implementation: I pushed a patch which updates the current slide for animations and slide transitions, too. Feel free to hack it further, maybe I missed some issue. Performance should be checked, too.

mcecchetti avatar Oct 17 '24 21:10 mcecchetti

Marco, thanks, about your patch I have forced push accidentally, anyway I have the history, if you can push it again.

hcvcastro avatar Oct 18 '24 11:10 hcvcastro

So, now looks good to me. Just a couple of notes to keep into account for a follow up.

1. It would be nice to have `PresenterConsole` in TypeScript as the other classes, since we're trying to migrate as much as possible to TS.

2. the current slide view has still aspect ratio issue

I am not happy to use a proprietary language that is not even a standard.

The aspect ratio of the current view is based on helper functions implemented. I will check it after merging the patches.

hcvcastro avatar Oct 21 '24 10:10 hcvcastro