Menu tab

[AbedrahmanYassen]

I have made the menu tab and used the logic at the settings screen in this tab, after that I have deleted the settings screen.

[Xazin]

Seems the analyzer is complaining.

In VSCode, it's a good idea to enable the "Format file on Save" option, such that the dart formatter will always make sure your files are formatted properly.

[Xazin]

Formatter still fails

[Xazin]

@AbedrahmanYassen How is it going?

[AbedrahmanYassen]

I will resolve it soon.

[AbedrahmanYassen]

@AbedrahmanYassen How is it going?

I made sure all the screens are formatted, what can be the problem?

[Xazin]

@AbedrahmanYassen How is it going?

I made sure all the screens are formatted, what can be the problem?

It's specifically complaining about Changed lib/presentation/home/home_screen.dart Changed lib/presentation/routes/app_routes.dart - You can try to run the dart format command and see.

Tests are also failing

[Xazin]

I've pushed a commit.

There were a lot of discrepancies according to Design. Take a look at my commit and it's changes, and have the figma beside you when you look it through.

Some of the generic mistakes:

• Don't use fixed sizing for Dynamically Sized Widgets
• When using BLoC, remember to account for loading state, otherwise you'll get a grey/red screen due to null guarantee ! where not applicable
• Size by spacing, correct spacing, font size, icon sizes, makes a bigger chance it's going to look according to design

And some other minor things.

[codecov[bot]]

Codecov Report

Merging #360 (5012b82) into development (1e9981e) will decrease coverage by 9.39%. The diff coverage is 15.94%.

@@               Coverage Diff               @@
##           development     #360      +/-   ##
===============================================
- Coverage        65.88%   56.49%   -9.39%     
===============================================
  Files              161      157       -4     
  Lines             4095     4064      -31     
===============================================
- Hits              2698     2296     -402     
- Misses            1397     1768     +371     

Impacted Files	Coverage Δ
lib/application/auth/auth_bloc.dart	0.00% <ø> (-49.40%)	:arrow_down:
.../application/participation/participation_bloc.dart	0.00% <0.00%> (ø)
lib/application/user/profile/profile_event.dart	0.00% <0.00%> (ø)
...application/user/profile_tab/profile_tab_bloc.dart	0.00% <0.00%> (-87.50%)	:arrow_down:
lib/core/config/network_config.dart	50.00% <ø> (-16.67%)	:arrow_down:
lib/domain/user/user.dart	100.00% <ø> (ø)
.../infrastructure/auth/firebase_auth_repository.dart	45.16% <0.00%> (+0.95%)	:arrow_up:
...astructure/crowdaction/crowdaction_repository.dart	0.00% <0.00%> (-100.00%)	:arrow_down:
...ucture/participation/participation_repository.dart	0.00% <0.00%> (-100.00%)	:arrow_down:
lib/presentation/auth/auth_screen.dart	1.96% <0.00%> (-0.04%)	:arrow_down:
... and 34 more

... and 6 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more