Colin Fay

Results 235 comments of Colin Fay

My short exploration leads to : ``` if (page == "all") { pages_retrieved 0 && is.finite(max_page) && pages_retrieved < max_page) { ``` Given that ``` > is.finite(NA) [1] FALSE ```...

Hey, This was also my first thought, that it would be nice to have it in the YAML, something like: ```yaml redirects: chapter-lorem: lorem chapter-ipsum: ipsum ``` And then after...

Hey y'all, If ever you want to see a "real life example", I've used it for the Engineering Shiny book. Step 1: Specified all the redirect here https://github.com/ThinkR-open/engineering-shiny-book/blob/master/_output.yml#L37 Step 2:...

Indeed, that would be better with a full HTML. Using the `rel = "canonical"` would also be a good choice, but I think the noindex should not be put because...

For `{golem}`, we have the following formatter `grkstyle::grk_style_transformer()` I suggest all {golem} contributor to add the following code to their .Rprofile. ```r # If you work in RStudio options(styler.addins_style_transformer =...

For the JS, I would suggest minifying too, for example with https://github.com/ColinFay/minifyr (requires nodejs)

Ah, yes, I've turned on "Format on save" in VSCode :)

closing if it's working, feel free to comment if you need the issue to be reopen :)

Very good idea indeed. I have a more or less fully functional regex here : https://github.com/ColinFay/backyard/blob/master/R/html_to_markdown.R We can mix your PR and the code from there so to include more...

From my perspective it would make sense to have something that allows that behaviour with other symbol like `"` — selecting the content, and returning before the first `"`. Also,...