requests_auth icon indicating copy to clipboard operation
requests_auth copied to clipboard

Enable domain name to be provided to authentication.BrowserAuth

Open ManojSN opened this issue 2 years ago • 2 comments

Hi Colin,

Please review the change and comment, I'll update the documentation add test cases when I get home.

The change is to allow domain name to be passed as an optional keyword arg. We have our OKTA setup in such a way that our company domain name is required even for localhost such as http(s)://localhost.somecompany.com:/<redirect-uri

Thanks

ManojSN avatar Oct 26 '22 17:10 ManojSN

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 26 '22 19:10 sonarqubecloud[bot]

@Colin-b -> pls review! as for the use of http://localhost triggering a sonar warning, guessing only you can accept the risk!

ManojSN avatar Oct 27 '22 14:10 ManojSN

Hello @ManojSN ,

Took 2 years but this will be part of the next release.

Colin-b avatar Jun 17 '24 16:06 Colin-b