twitch-graphql icon indicating copy to clipboard operation
twitch-graphql copied to clipboard

Tests are still hitting the twitch api

Open ColeWalker opened this issue 5 years ago • 4 comments

Some of our tests are still hitting the twitch api, which is not ideal for rapid testing.

ColeWalker avatar Oct 08 '20 18:10 ColeWalker

Thanks Cole, I'll see if I can tackle some of this, no promises yet

CodeItQuick avatar Oct 08 '20 19:10 CodeItQuick

This was a misunderstanding/miscommunication on my part and can be closed?

CodeItQuick avatar Oct 10 '20 16:10 CodeItQuick

I added a PR that addresses one of the endpoints that currently hits the Twitch API and significantly speeds up the tests.

CodeItQuick avatar Oct 10 '20 18:10 CodeItQuick

User-subscriber link still hits twitch api. https://d-fischer.github.io/twitch/reference/classes/HelixSubscription.html

ColeWalker avatar Oct 11 '20 15:10 ColeWalker