Kevin Chung
Kevin Chung
Yes this is a little bit b/c it was migrated from the previous versions of CTFd which used raw forms and I was an even worse developer way back then....
I think this PR is fine. If you could edit your issue description to just talk about the remaining issues that would be ideal. Regarding plugins, CTFd plugins basically can...
One improvement for another PR I think might be if there's a way to test the validity of the generated swagger file.
PR welcome. You could maybe surface a log message via the sendmail wrapping function.
Very odd, I wonder if this is perhaps fixed with a more recent version of MariaDB? I feel like the proposed fix for this is the wrong direction. The migration...
See https://github.com/CTFd/CTFd/pull/2601/commits/d659f43f8798bf563a1e1917b0364b92310b16e5 and https://github.com/CTFd/CTFd/issues/2600#issuecomment-2365065037 to get MariaDB working properly under Windows Docker Desktop with WSL2.
Great news, thank you!
I don't like the usage of inspect here to be honest. Would a symlink not work for you?
I feel like the IP tracking should occur on account creation. Can you see if it shows up in the Tracking table after creating a user? If not maybe we...
Makes sense, the plugin shouldn't have to worry about subdirectory deployments. You can PR a fix if you'd like.