Kevin Chung
Kevin Chung
@HamishWHC Try out the new config added in #2796
@pandatix Can you elaborate on what you are looking for? On Sun, Aug 11, 2024 at 3:27 AM Lucas Tesson ***@***.***> wrote: > Hello, quick question as there is additional...
I think best to just deprecate this for now and notify via the UI and in documentation.
I agree with some of this but I don't think stripping flags is the right idea. Could people have flags with whitespace at the end? Do we want to prevent...
I don't really like the solutions here and I don't think this is really that big of an issue.
An interesting point is that CTFd has actually always stripped flags when they are submitted by users. Meaning that a flag ending in a space is actually impossible.
Regarding the above: https://github.com/CTFd/CTFd/blob/61d2bddaed393ce5be5a1e911be09522bebaf523/CTFd/plugins/challenges/__init__.py#L122 attempt, solve, and fail methods all used strip(). So we should be okay to strip regular static and regex flags. Other flags I will leave as...
I think ultimately the healthcheck should be handled by a seperate service and CTFd can poll that. In your implementation how would you check the health of a plain TCP...
I’m not against this but it would be faster for you to implement it as a plug-in and then we can see how it works in practice before changing things...
This PR shouldn’t need to bump any dependencies. On Sat, Oct 26, 2024 at 4:32 AM br0xpl ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > >...