Line numbers misaligned in 4.5

[ghost]

As above.

It would be really good and maybe more maintainable long term if you can work with Eclipse maintainers to embed this directly into the platform (@vogella seems to be a good contact)?

[ColdDevil]

Hey @ovinn! Thanks for your comment. Yes, that would be great and I added my patch to the platform code review more than a year ago (cf. https://git.eclipse.org/r/#/c/21478/) and it is currently under discussion :) I hope it will be included in Eclipse Mars! Kind Regards Flo

[Rodneyh303]

Looks like it didn't make it into Mars. Regarding the line number misalignment in 4.5 I think it's related to the Jface plugin. At http://dev.cdhq.de/eclipse/word-wrap/ there are alternate org.eclipse.jface.text for 4.2,4.3,4.4.

Where does these come from and do they contain any modifications to run with de.cdhq.eclipse.wordwrap?

What version should we use with 4.5?

In a Mars installation I took the risk of removing from eclipse's plugin folder the org.eclipse.jface.text that came with Mars after installing the Luna version of the plugins from http://dev.cdhq.de/eclipse/updatesite/luna/

I then ran eclipse -clean and it runs. I've briefly tested it with Texlipse (Lorem ipsum demo like at cdhq) and the line number behaviour in Mars is then working fine under word wrap as it is in Luna. But I suspect a more up to date "changed" org.eclipse.jface.text for Mars might be needed?

I noticed that org.eclipse.jface.text_3.8.101.v20140206-1337.jar was used for both Juno and Kepler.

Replacing Mars's org.eclipse.jface.text_3.10.0.v20150603-1752.jar with org.eclipse.jface.text_3.10.0.201407301033.jar seems risky but so far it works OK at least for Texlipse.

[kachkaev]

Same issue here too. Line numbers do not show up correctly after upgrading to Mars (I installed the plugin from http://dev.cdhq.de/eclipse/updatesite/luna/ and then ran /...../eclipse -clean). Any chance for a fix and a new download link (http://dev.cdhq.de/eclipse/updatesite/mars/)?

[ColdDevil]

Hey there! Yes, unfortunately there were some SWT bugs that prevented the patch from being reviewed and therefore it didn't make it into Eclipse Mars. I hope at the end of next week I'll find some time to update the patch and support Eclipse Mars! Kind Regards Florian

[vogella]

Also your Gerrit review has some open item. The SWT bug is fixed in Neon. Am 03.09.2015 9:02 vorm. schrieb "Florian Weßling" <[email protected]

:

Hey there! Yes, unfortunately there were some SWT bugs that prevented the patch from being reviewed and therefore it didn't make it into Eclipse Mars. I hope at the end of next week I'll find some time to update the patch and support Eclipse Mars! Kind Regards Florian

— Reply to this email directly or view it on GitHub https://github.com/ColdDevil/de.cdhq.eclipse.wordwrap/issues/10#issuecomment-137355928 .

[stalker780]

Latest PDT 4.6 (from http://p2-dev.pdt-extensions.org/) is in conflict with Line Ruler Fix for Eclipse 4.5

Cannot complete the install because of a conflicting dependency. Software being installed: Line Number Ruler Fix (Eclipse Mars 4.5) 0.0.1 (de.cdhq.eclipse.linenumberfix.mars.feature.feature.group 0.0.1) Software currently installed: PHP Development Tools (PDT) 3.6.0.201509121653 (org.eclipse.php.feature.group 3.6.0.201509121653) Only one of the following can be installed at once: Text Editor Framework 3.9.100.v20141023-1946 (org.eclipse.ui.workbench.texteditor 3.9.100.v20141023-1946) Text Editor Framework 3.10.0.201509112319 (org.eclipse.ui.workbench.texteditor 3.10.0.201509112319) Cannot satisfy dependency: From: Line Number Ruler Fix (Eclipse Mars 4.5) 0.0.1 (de.cdhq.eclipse.linenumberfix.mars.feature.feature.group 0.0.1) To: org.eclipse.ui.workbench.texteditor [3.10.0.201509112319] Cannot satisfy dependency: From: Dynamic Languages Toolkit - Core Frameworks 5.3.0.201509040407 (org.eclipse.dltk.core.feature.group 5.3.0.201509040407) To: org.eclipse.platform.feature.group 3.4.0 Cannot satisfy dependency: From: PHP Development Tools (PDT) 3.6.0.201509121653 (org.eclipse.php.feature.group 3.6.0.201509121653) To: org.eclipse.dltk.core.feature.group 5.3.0 Cannot satisfy dependency: From: Eclipse Platform 4.5.0.v20150603-2358 (org.eclipse.platform.feature.group 4.5.0.v20150603-2358) To: org.eclipse.ui.workbench.texteditor [3.9.100.v20141023-1946]

[eulerreich]

In 4.5 toggling gets switched off after switching panes inside eclipse (with texlipse enabled; I don't know if this breaks without texlipse)