coldbox-platform icon indicating copy to clipboard operation
coldbox-platform copied to clipboard

🤖 - Add Lucee 5.3 RC experimental builds

Open michaelborn opened this issue 2 years ago • 3 comments

This PR will allow us to test ColdBox against the latest Lucee RC or SNAPSHOT without halting the current ColdBox release. This will give us (and Lucee!) early warning against Lucee 5.3.x compatibility issues.

michaelborn avatar Sep 29 '22 16:09 michaelborn

Am converting this to a draft PR until we decide on a path forward - either add a server.json or switch to passing cfengine in the server start command.

michaelborn avatar Sep 29 '22 16:09 michaelborn

Could you update this PR to see how it would look like if we removed all the server-*.json files?

lmajano avatar Sep 30 '22 08:09 lmajano

Could you update this PR to see how it would look like if we removed all the server-*.json files?

My apologies @lmajano , I missed this comment! Yes, I can update to remove the server-*.json files.

michaelborn avatar Oct 12 '22 14:10 michaelborn

Switching back to a "Draft" PR. After discussing w/ Luis, the multiple server-*.json files make local development much easier, so I'm going to revert to that setup.

michaelborn avatar Oct 26 '22 13:10 michaelborn

@lmajano I believe this PR is ready for a second look. Keep @bdw429s 's notes in mind when looking at the updated ACF 2021 install scripts. After all... if we REALLY needed those scripts, the build would fail, wouldnt it? :smile:

michaelborn avatar Nov 10 '22 14:11 michaelborn

@michaelborn do you mind resolving the conflicts please

lmajano avatar Nov 14 '22 10:11 lmajano

Done @lmajano !

michaelborn avatar Nov 14 '22 14:11 michaelborn