Colin Carroll

Add some tests for venv.py

3

Test coverage moving on up (35 -> 45)! Still thinking about how to mock installing requirements -- I wonder if adding a `pypi` file to the `tests/fixtures/` directory, and just...

Branch of main project with `theano` commented out

1

I tried to do this mostly agnostically, but added a few pieces of pytorch code... [This commit](https://github.com/ColCarroll/pymc3/tree/09c2e388e95b6f1904e2d4c39566b16a38d65d64) should keep pointing to a project where `import pymc3` works without theano. The...

Check last point when using best so far minimiser

1

Fixes #33 There is some unnecessary looking lines ``` best_f, best_aux = fn(state.best_y, args) best_loss = self._to_loss(state.best_y, best_f) ``` where I would expect to just use `state.best_loss`, but the test...

BestSoFarMinimiser behavior

1

Not sure if this is a bug or not, but `BestSoFarMinimiser` appears to not check the last step of the wrapped solver: ``` solver = optimistix.BestSoFarMinimiser(optimistix.BFGS(rtol=1e-5, atol=1e-5)) ret = optimistix.minimise(lambda...