Matt

Results 239 comments of Matt

Closing now that 4.X has the same functionality, we can continue from there rather than on this 3.X branch

Something to possibly consider in #579

Skipping a few other formatting comments, as I'll just apply the formatter when merging.

Live search has been adapted into the 4.x branch

Closing as this has since been resolved in 4.X

Would be very cool to implement a `ClassVisitor` that remaps the metadata annotation to a custom one that shows the data in plain text. That way we can simply insert...

Can begin working on this now with: https://github.com/Col-E/Recaf/commit/14976b2f2ff2bfee05bcfdcc512a9cde3fe46f73

That seems like it is already tracked: - https://github.com/ThexXTURBOXx/dex2jar/blob/main/dex-reader-api/src/main/java/com/googlecode/d2j/node/DexClassNode.java#L31 - https://github.com/ThexXTURBOXx/dex2jar/blob/main/dex-reader/src/main/java/com/googlecode/d2j/reader/DexFileReader.java#L835 The test class `AppWriterTest` pulls from the test resource `i_jetty.dex` which contains source files. Looks like it works to...

Another recent case: ``` java.lang.IllegalArgumentException: newLimit < 0: (-10 < 0) at java.base/java.nio.Buffer.createLimitException(Buffer.java:395) at java.base/java.nio.Buffer.limit(Buffer.java:369) at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:1529) at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:267) at software.coley.lljzip.util.ByteDataUtil.sliceExact(ByteDataUtil.java:302) at software.coley.lljzip.util.BufferData.slice(BufferData.java:83) at software.coley.lljzip.util.ByteData.sliceOf(ByteData.java:108) at software.coley.lljzip.util.ByteDataUtil.lambda$readLazyLongSlice$7(ByteDataUtil.java:508) at software.coley.lljzip.util.lazy.LazyByteData.get(LazyByteData.java:49) ```...

Generally avoiding reflection is a good start, but I have to ask why would you be concerned about DI performance?