Recaf icon indicating copy to clipboard operation
Recaf copied to clipboard

Remap methods and properties

Open emyfops opened this issue 9 months ago • 7 comments

On the latest build of recaf, applying tinyv2 mappings will only remap class names and not methods or properties

emyfops avatar Apr 04 '25 20:04 emyfops

Please provide a sample & mappings file that reproduces the issue

Col-E avatar Apr 04 '25 20:04 Col-E

Please provide a sample & mappings file that reproduces the issue

mappings.txt (renamed to .txt) tiny mappings srg->mcp minecraft 1.7.10

I don't have a sample on hands, any mc mod for 1.7.10 will do it

emyfops avatar Apr 04 '25 22:04 emyfops

Log output

Applied mapping to 748 classes
Applied mappings from mappings.tiny - Updated 748 classes

No mentions of remapping methods or properties, check the class files, only classes are remapped

Image

emyfops avatar Apr 04 '25 22:04 emyfops

I have tried using Recaf to remap the mod of 1.20.4, and the mapping table is of tiny v2. I didn't find any particular problems. remap is perfect. If you say it's version 1.7.10 of minecraft, then it might not be a mapping table in the Tiny v2 format. The mapping table of forge is in srg format.

luiox avatar Apr 18 '25 14:04 luiox

Class names are remapped correctly but method and fields that are present in the tinyv2 file are not remapped in places where they are called

emyfops avatar Apr 18 '25 15:04 emyfops

I have used the mappings viewer from wagyourtail to generate the mappings

emyfops avatar Apr 18 '25 15:04 emyfops

Can you provide a mapping table and jar? I would like to try reproducing it.

luiox avatar Apr 19 '25 02:04 luiox

I assume this is an artifact of not providing the appropriate intermediate jar to the workspace.

You can now bypass this with the steps outlined here with the new Mapping > Advanced Apply - #901

Col-E avatar Jul 28 '25 01:07 Col-E

@Col-E yup that was it, I was able to apply srg mappings as a tinyv2 file using the advanced apply and checked the assume unique key button

emyfops avatar Jul 28 '25 13:07 emyfops