Recaf icon indicating copy to clipboard operation
Recaf copied to clipboard

Mappings are not applied to currently open files (4.0.0-SNAPSHOT)

Open solonovamax opened this issue 1 year ago • 3 comments

Describe the bug

When applying mappings, the currently open files are not remapped

To Reproduce

Steps to reproduce the behavior:

  1. Download any fabric minecraft mod
  2. Download & extract the appropriate yarn mappings for the mod
  3. Select a class file to open & decompile
  4. Apply the yarn mappings
  5. Currently opened class file is not remapped

Exception

N/A

Screenshots

N/A

solonovamax avatar Sep 27 '24 17:09 solonovamax

Under the "Decompile Pane" config there is an option titled "Accelerate remapping operations" which will use update the AST rather than re-decompile the whole class after changes. In obfuscated scenarios its generally best disabled. Perhaps that could affect this a bit?

Also for reproduction, can you provide a sample that consistently demonstrates the problem?

Col-E avatar Sep 27 '24 23:09 Col-E

Under the "Decompile Pane" config there is an option titled "Accelerate remapping operations" which will use update the AST rather than re-decompile the whole class after changes. In obfuscated scenarios its generally best disabled. Perhaps that could affect this a bit?

I'm using whatever the default configuration is for recaf, so unsure if I have this enabled.

For sample (although unsure if it reliable reproduces it), just use the exact same class & source jar from my other few issues.

solonovamax avatar Sep 29 '24 21:09 solonovamax

just use the exact same class & source jar from my other few issues

If it was the same as #862 then I'd close this. If there is another sample that doesn't fall under the problem described in my reply there, please provide a copy here.

Col-E avatar Sep 29 '24 23:09 Col-E

See the new Mappings > Advanced Apply window #901 (Specifically the option to ignore hierarchy)

Col-E avatar Jul 28 '25 01:07 Col-E