Cœur

Results 652 comments of Cœur

@PinwheelAi Can you check your spelling? You created _Cocopods-local_ but in your podfile you wrote _cocoapods-local_.

@perrick his website www.lastcraft.com is also down. You could try to reach him on LinkedIn maybe: https://www.linkedin.com/in/lastcraft/

@nmathewson can you give it a review?

@azat can you give it a review? The description of the PR explains well what is the issue: two different inputs can have identical hash, which is not good.

@azat can you review and merge it?

Let me quote a recent article on the topic: https://blog.trailofbits.com/2024/08/21/yolo-is-not-a-valid-hash-construction/ >The Problem >[...] Then we have YoloMultiHash(M̂) = YoloMultiHash(M̃). **That’s two semantically distinct inputs that lead to the same hash...

It works without collision if and only if the last two bits are always zero. And that addition still doesn't add any benefit. To be "safe" while keeping the addition,...

@SunnyPaprika I've change the PR to be a documentation change, explaining that the code is wrong in any scenario, but with different solutions depending on the actual situation. @azat feel...

Why was the PR closed, @zuiwuchang ?

This pull request was made from the **master** branch of @powerpuffpenguin, which is used for releases apparently, so that PR is unlikely going to be updated to remove the GCC