Cœur
Cœur
I see. So, in a sense, you suggest .zip instead of .dmg for distribution.
> AFAIK, zip cannot be signed. We don't really need the archive to be signed, as far as it has a documented valid hash and that the .app itself is...
So, thank you for the feedback @jslawler-gh, but we won't be implementing .zip releases for macOS.
I have no idea if it's the same issue, because you're on Windows, but on macOS when it happens, I **restart the computer** and torrents start connecting to peers afterward....
I suppose it's to silence a warning of some sort? Because in order to get null here, we would need `calloc(1, sizeof(struct evhttp)))` to fail, meaning absolutely no memory left...
> I think there needs to be a proper return value or log here, but I'm not quite sure how to log is preferred.... ``` tr_logAddError(fmt::format(_("Couldn't instantiate httpd for '{server}'"),...
We'll have converted the codebase to Rust before it happens.
> Nice fix! We could credit @stefantalpalaru since that's iso what he suggested back in June 2023 (see https://github.com/transmission/transmission/pull/6752 description and link)
I don't know why, but we still have crashes with this branch. This time it's here: https://github.com/transmission/transmission/blob/92519281b03bb31ddbdb723883d56fe9b4a0a52d/libtransmission/peer-mgr.cc#L437 is_incoming is false. I've "worked-around" it with this code: ``` [[maybe_unused]] size_t count;...
From the look of it, it was caused by #5992? @tearfur @ckerr do we revert it? Or it's a duplicate of #5853?