Cody Bennett comments

Results 363 comments of


                                            Cody Bennett

trafficstars

React Native Conflicting peer dependency

@drcmda, either we add native support to use-measure and make react-dom an optional peer dep there, or we drop it from R3F in the meantime.

[v9] chore: replace forwardRef with props.ref

I missed this PR, but the changes are indeed unrelated. You likely have a broken build or duplicated installs of R3F itself. We're working on getting RC channels of libraries...

instancedMesh onClick behavior

I would first find a working version and go from there. R3F doesn't interfere here, but three.js has made changes alongside the timeline of this issue, which would affect you,...

Performance degradation with `onDoubleClick` Event Handler

Maybe configuring which events we listen to in the default implementation could be a simple improvement. I'd open another issue if you want to continue on this. Otherwise, events can...

Resizing the window resets render shadowMap type and/or explodes them.

Feel free to make a PR. Windows will need to be configured for symlinks, but our examples folder will automatically link and use your changes. Alternatively, each commit to your...

Creating a texture with Float32Array, gl.FLOAT format

Is this a DOM upload, or are you rendering to a float render target? Note that linear filtering for float textures requires `OES_texture_float_linear` where support has regressed on Apple platforms....

Creating a texture with Float32Array, gl.FLOAT format

I wonder if this is simply missing `gl.getExtension('EXT_color_buffer_float')`.

WebGPU uniforms and alignment (?)

I'm not able to observe this issue. This is the expected memory layout for the shader ([offset calculator](https://webgpufundamentals.org/webgpu/lessons/resources/wgsl-offset-computer.html#x=5d000001009a04000000000000003d888b0237284c23437623aab4a783e1cb48ceab963da45a6dccf86e77c2c31e403a25129667138f6f0a07711be86c90f7b3ae0d1153a17b49b7fbc5e24aeef417e0d4c56065c994a514a5442669b0409cd19ccb29b154fc4859870aeadfbf36cd35554265209414e76aea6e999988eb766b33b32d5a946e5e370a5615d49f7f4998b81fcd423bafa442c53019213e4654cd1486c857eb17c362425f5ae05f9c650c0bd2ba6aad907819385056f1054cbf8ba41c9c6d6a9a555588c4c147771150459b6cf346aaddc4792badce08b2c911ab9841795702710bd8c99ae844a23694ac7d0b8d6daa1572f9465981a7c37c2d1f2d1c4a94c4cf67acbbcad71a33e809f6749d0c580cf967d1bd9c1f203271ac268d557647cf52e2cb90e8abd9e4f7883c6ab98da18d2ea908b32d5bbc4271a4d1ae4de7a1163423f4f2ea842e0f4705c1a70b738798dfdd2bf883f8128d0962137284dfdf5d7f7230882bf2c22beba470f046f3fba3b39a59361302448a0edd7c05b6f34b34565a3b415771dfea2c3d842dd7646f64f4546a1316f2829ecbd964b1bf5d3e2a82b4bb55bb528f34578c3152688e6b0ebc0b0469dd48173ee92a1f36a8dccd58b515971cccc139fc093547674c58b8cfb15871febb12fdf7500d)):

React 19?

`prepareUpdate` was removed, and the update payload in `commitUpdate` as well. This is likely causing the breakage. You can see the shell types I implemented in react-three-fiber as a reference:...

Applications is blicking when shared via Microsoft Teams

We can't do anything without a reproduction and frankly I think there's more to be done on your side to whittle this down. If you need a vanilla example, this...