pr-agent icon indicating copy to clipboard operation
pr-agent copied to clipboard

[Feature Request] Include /review -i in GitHub App automation

Open esauser opened this issue 2 years ago • 7 comments

The GitHub App automatically runs /review when a PR is opened, but it does not do anything to subsequent pushes to the PR. We'd like to run /review -i for each subsequent push.

esauser avatar Jul 29 '23 03:07 esauser

I would like to add perhaps it could be an option. I prefer to re-request review personally.

bperreault avatar Jul 29 '23 11:07 bperreault

i believe #215 is right for this purpose correct @tjwp ?

idavidov avatar Aug 18 '23 06:08 idavidov

This would need some additional changes to handle incremental. It would need to look for a synchronize action on a PR and trigger an incremental review (only available by arg currently). It should probably be an additional setting.

tjwp avatar Aug 18 '23 10:08 tjwp

i am not sure you would like review to be run automatically every new commit. it can flood the git with a lot(!) of messages.

my suggestion - use it manually, when needed.

mrT23 avatar Oct 03 '23 16:10 mrT23

This can almost be accomplished already. synchronize can be added to the handle_pr_actions and improve -i can be added to pr-commands. The only thing missing is being able to do it differently the first time vs. every time.

If the config was separated out to allow you to specify specific commands for specific actions we'd have that flexibility. Maybe something to consider @mrT23 .

esauser avatar Oct 05 '23 05:10 esauser

Technically its possible, i agree.

However, optional features still need to be viable. In practice, even as an option, would you really want 10-20 long review feedback messages in a single PR ? we tried this way (Triggering on every commit) when starting developing pr-agent, and it was awful

I think a better option is to enable to update the initial review message after every commit, so review feedback will always be up-to-date.

but I am not sure. open for feedback

mrT23 avatar Oct 05 '23 05:10 mrT23

@mrT23 I would expect it to update existing, yes.

esauser avatar Oct 05 '23 05:10 esauser