website-archive icon indicating copy to clipboard operation
website-archive copied to clipboard

166 ASCII Image: charIndex out of bounds for white pixels

Open jogerj opened this issue 3 years ago • 1 comments

in sketch.js, the charIndex of a pixel is calculated as follows: const charIndex = floor(map(avg, 0, 255, 0, len)); Instead, it should be const charIndex = floor(map(avg, 0, 256, 0, len)); because otherwise whites (rgb 255, 255, 255) will be mapped to the exact length of the density string which returns '' (an empty string) instead. This results in tearing on videos. The tricky bit was charAt didn't report any error when accessing out of bound index so it went unnoticed.

Nice tutorial btw

jogerj avatar May 12 '22 01:05 jogerj

Hi Jogerj!

Thank you for submitting this errata! You can make a pull request for the fix if you want to! We'll be moving to a new website soon so if this issue is still open when we move I'll add the fix myself!

KobeLiesenborgs avatar May 16 '22 19:05 KobeLiesenborgs