thecodingtrain.com icon indicating copy to clipboard operation
thecodingtrain.com copied to clipboard

Preview link in passenger showcase guide

Open DenisovichDev opened this issue 2 years ago • 8 comments

Under SUBMITTING A PULL REQUEST I think it's worth mentioning that in the description of the PR it's good to have a preview link. Since we don't have that template thing like we did in the old repo anymore.

I think this screenshot could have a preview link or picture: image

DenisovichDev avatar Oct 21 '22 11:10 DenisovichDev

Good call! I'm also not opposed to adding templates for issues and pull requests if you have ideas on what would be most helpful to the community!

shiffman avatar Oct 21 '22 14:10 shiffman

@shiffman I can work on some templates for PR and issues if you like! I think something minimal would be the best. I'll get working on the edits to be made in the guide for now then.

DenisovichDev avatar Oct 22 '22 13:10 DenisovichDev

Sounds great! The reason I am slow to do this one and #628 is changing the screenshots maybe requires doing all of them so that they have the same look and feel?

shiffman avatar Oct 22 '22 13:10 shiffman

Yes I have that in my mind. I can try make it look similar with a bit of editing. And if it doesn't look very good at the end, we can keep it in hold while we get the screenshots ready for it. There's no rush anyway

DenisovichDev avatar Oct 22 '22 13:10 DenisovichDev

For PR Templates, I think the following versions are possible:

  • Porting a Track
  • Porting a Challenge
  • Showcase Submission

dipamsen avatar Oct 24 '22 08:10 dipamsen

Agreed! This is a tiny point but I think we can consider them "Creating a Track" or "Creating a Challenge Page" since it ultimately is less about porting and more about making the content for the site! Also, we are close to getting all of the older challenges done so I'm not sure how much longer that will be relevant! (There are probably so many ways that side tracks can be configured).

shiffman avatar Oct 24 '22 13:10 shiffman

That is true!

dipamsen avatar Oct 24 '22 13:10 dipamsen

Ah thank you @dipamsen!

DenisovichDev avatar Oct 24 '22 15:10 DenisovichDev