CapacitorGoogleAuth icon indicating copy to clipboard operation
CapacitorGoogleAuth copied to clipboard

Update GoogleSignIn pod to 7.1.0

Open rafael-rentman opened this issue 1 year ago • 13 comments

Updated the GoogleSignIn dependency to:

  • include necessary privacy manifests
  • ensure compatibility with newer Google MLKit based capacitor plugins (E.G. @capacitor-mlkit/barcode-scanning)

rafael-rentman avatar Oct 18 '24 14:10 rafael-rentman

thank you for your work :)

is it worth changing anything for andoid /web ? should something be added to the readme ? Were you able to test locally ?

reslear avatar Oct 18 '24 15:10 reslear

Glad to help!

  • As far as I know there are no dependency issues on the android/web side
  • Sharp! Yes, a small change in configuration: for iOS it's now required to add the clientId of the app to the .plist, I will update the readme
  • I have tested the package in our app on an actual device using xcode, logged in users stay logged in, logging in/out works as expected.

rafael-rentman avatar Oct 18 '24 15:10 rafael-rentman

Good, I'm guessing it's breaking change

By the way, can you add a link to the official documentation about GIDClientID?

reslear avatar Oct 18 '24 16:10 reslear

@rafael-rentman people do depend on the ability to have a runtime defined GID So if it's required to have it, then the runtime google GID for android should be removed and noted as deprecated. Link: https://developers.google.com/identity/sign-in/ios/release

riderx avatar Oct 18 '24 21:10 riderx

@rafael-rentman people do depend on the ability to have a runtime defined GID So if it's required to have it, then the runtime google GID for android should be removed and noted as deprecated. Link: https://developers.google.com/identity/sign-in/ios/release

Fair enough, I will take a closer look.

@riderx Can you name some examples of situations where a runtime defined GID is necessary?

rafael-rentman avatar Oct 24 '24 08:10 rafael-rentman

For what i have seen, in ealier issue, people want to allow login and api usage with different credentials, so at runtime the connection is done. This feature has been done not so long ago by some users who needed it, so they would loose this. If possible it’s preferable to keep it

riderx avatar Oct 25 '24 03:10 riderx

Mmh it seems like this will not work with the GoogleSignIn pod going forward. I still don't understand why anyone would want to have multiple GID's for a single app in production... If it is to separate dev from prod it is a non-issue anyway, then it should just be changed in the config

rafael-rentman avatar Nov 06 '24 09:11 rafael-rentman

I still don't understand why anyone would want to have multiple GID's for a single app in production.

Is that how it is now? Can you give me an example? How it was? How it will be.

reslear avatar Nov 06 '24 14:11 reslear

Mmh it seems like this will not work with the GoogleSignIn pod going forward. I still don't understand why anyone would want to have multiple GID's for a single app in production... If it is to separate dev from prod it is a non-issue anyway, then it should just be changed in the config

For example, connect to different google services if your app connects to one GID for Login and one for calendar. But the question is not really why, the point is you cannot remove a feature without going a breaking change.

riderx avatar Nov 08 '24 18:11 riderx

@rafael-rentman ready for merge?

reslear avatar Jan 06 '25 10:01 reslear

I think, it will never be as it is. but the alternative we made is fully ready and capable of it

riderx avatar Jan 06 '25 14:01 riderx

I didn't have time yet to make the required changes and our fork currently meets our needs.

rafael-rentman avatar Jan 21 '25 09:01 rafael-rentman

This plugin is "virtually" archived as there no way to reach the author in any medium. Please use: https://github.com/Cap-go/capacitor-social-login as alternative follow migration here We implemented all the requirements.

riderx avatar Jan 21 '25 11:01 riderx