CodesInChaos

Taking `&mut self` while returning a status indicator instead of the actual result saves one ref-count increment/decrement.

The attack `RequireAddressValidation` is designed to prevent is an attacker sending a large number SYN-packets\* where the sender IP-address is forged (similar to [SYN floods](https://en.wikipedia.org/wiki/SYN_flood) in TCP). Since the attacker...

The fundamental challenge is that edgedb requires primary keys to be unique-per-database and not unique-per-table like most databases. This makes supporting custom primary keys very difficult to support. I think...

Couldn't you first generate the id, and then insert the object setting both the object's id and the link target to that id at the same time? Since the id...

Personally I don't trust code involving booleans or the `==` operation in the constant time part, which rules out the `and` based code you posted. Between substraction and xor I...

You could also simply call the constructor that takes parameters. What I did was the smallest change to actually make it compile.

I've added code fixing the quality problems in safe mode for Vector2, Vector3, Vector4 and Quaternion and added a unit tests to verify if equality behaves as expected. I assume...

Under which circumstances do you want to encrypt/decrypt data in the database, instead of the application? Also, the functions descriptions at [F.28. pgcrypto — cryptographic functions](https://www.postgresql.org/docs/current/pgcrypto.html) are very difficult to...

The ciphertext will always be `bytes`, and the plaintext will either be a string, or bytes as well. So there isn't much type safety to be had here. I'd define...

> Is the module going to be used frequently, btw? Originally I though, *yes*. But reconsidering it, I'm not so certain. The most popular types map to standard rust types,...