Paolo Cunti @codencode
Paolo Cunti @codencode
Hello @kpodemski, I think it could be an idea, but we should consider that the issue no longer occurs in PrestaShop version 9. Maybe it's better to ignore this problem?
@kpodemski, Would you perform the code check between the 2 environments in the method `SymfonyCacheClearer::clear() `https://github.com/PrestaShop/PrestaShop/blob/e94033735318d78ba5e43283f7bd1bf2094c081b/src/Adapter/Cache/Clearer/SymfonyCacheClearer.php#L92-L100, or in `AppKernel::getContainerClearCacheLockPath() `https://github.com/PrestaShop/PrestaShop/blob/e94033735318d78ba5e43283f7bd1bf2094c081b/app/AppKernel.php#L269-L275? In the first case, it would be: ```php # src/Adapter/Cache/Clearer/SymfonyCacheClearer.php...
@kpodemski with version 9 this problem never occurred. So yes, you're right and I'll close the PR
> Sorry, but this is a BC break. :-( Hello @Hlavtox , You are right, I hadn't thought about that and I have never encountered such a situation before. What...
> @Codencode Yep, it would be good for it to be fixed. :-) > > You have two options: > > * Put the $idCustomization parameter to the end of...
@Hlavtox I made the changes as suggested. Thank you.
> Code wise it's good!!! :-) Thank you!
> Apologies for long time to merge, thank you @Codencode No problem, thank you @matks
I have created a PR for issue 2 PR: https://github.com/PrestaShop/PrestaShop/pull/36287
> Then it should work, but one usecase is broken. > > * If `$destinationFileType` is `jpg` and `$forceType` is `false`, it will auto decide ONLY between JPG and PNG....