neve icon indicating copy to clipboard operation
neve copied to clipboard

feat: added scroll to top cta

Open preda-bogdan opened this issue 1 year ago • 6 comments

Summary

Added new upsell control for Scroll To Top CTA.

Will affect the visual aspect of the product

YES/NO

Screenshots

Neve Free Scroll To Top Upsell

image

Test instructions

  1. On a fresh instance of Neve w/o. Neve Pro
  2. Check that inside the Customizer on Layout > Scroll To Top the upsell is present, with disabled controls, and the upsell link works.
  3. Check that after activating Neve Pro the upsell is no longer present and the module is available as before.

Check before Pull Request is ready:

  • [ ] I have written a test and included it in this PR
  • [x] I have run all tests and they pass
  • [x] The code passes when running the PHP CodeSniffer
  • [x] Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
  • [x] Security and Sanitization requirements have been followed
  • [x] I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes Codeinwp/neve-pro-addon#2734.

preda-bogdan avatar Feb 06 '24 12:02 preda-bogdan

Plugin build for f307dbbb1d9f15fc48ba465123b0dd7a20cc6bb4 is ready :bellhop_bell:!

pirate-bot avatar Feb 06 '24 12:02 pirate-bot

@preda-bogdan Tested and everything works fine, except for how the range controls look when Neve Pro is not active https://vertis.d.pr/i/tcwyPY

irinelenache avatar Feb 07 '24 15:02 irinelenache

@irinelenache can you let me know what browser you used? Thank you!

preda-bogdan avatar Feb 07 '24 15:02 preda-bogdan

@preda-bogdan Chrome Version 121.0.6167.160 / macOS 12.2.1 / Built-in Liquid Retina XDR Display 14-inch (3024 × 1964)

I see the issue is visible also in the screenshot you provided

irinelenache avatar Feb 07 '24 16:02 irinelenache

@irinelenache Sorry for that, there was a typo in CSS that I introduced when changing the target. It should look correct now. I also updated the screenshot.

preda-bogdan avatar Feb 08 '24 07:02 preda-bogdan

@preda-bogdan Everything's fine now, thank you 🚀

irinelenache avatar Feb 08 '24 14:02 irinelenache

:tada: This PR is included in version 3.8.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

pirate-bot avatar Feb 22 '24 13:02 pirate-bot