neve icon indicating copy to clipboard operation
neve copied to clipboard

fix: description visible in regular menu

Open preda-bogdan opened this issue 1 year ago • 4 comments

Summary

Do not show item descriptions in regular navigation. Added e2e test for this specific case.

Will affect the visual aspect of the product

YES

Screenshots

Test instructions

  1. On a fresh instance of Neve FREE
  2. Change an existing menu item to have a description or use a category with a description as a menu item.
  3. Check that the description is not visible inside the navigation when the item is nested under a main item.

Check before Pull Request is ready:

  • [x] I have written a test and included it in this PR
  • [x] I have run all tests and they pass
  • [x] The code passes when running the PHP CodeSniffer
  • [x] Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
  • [x] Security and Sanitization requirements have been followed
  • [x] I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes #4199.

preda-bogdan avatar Feb 01 '24 15:02 preda-bogdan

Plugin build for 251b2cc14d04f82d1bb2a82fe4bd6fda908dad6a is ready :bellhop_bell:!

pirate-bot avatar Feb 01 '24 15:02 pirate-bot

@preda-bogdan Tested and the issue seems to be fixed, but now the Items description in the mega menu are not visible anymore. Here is a video with the behaviour before and updating with the PR https://vertis.d.pr/v/mqNPGV

Can be checked here:

 Admin area URL: https://bangplace.s1-tastewp.com/wp-admin 
 Username: irinel 
 Password: 7K2lllN5-i0 

irinelenache avatar Feb 02 '24 13:02 irinelenache

@irinelenache thank you for checking this, I updated the condition to allow the mega menu description as before. Let me know if the issue is resolved now.

preda-bogdan avatar Feb 06 '24 08:02 preda-bogdan

@preda-bogdan Tested again and everything's fine now, thank you 🚀

irinelenache avatar Feb 06 '24 15:02 irinelenache

:tada: This PR is included in version 3.8.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

pirate-bot avatar Feb 22 '24 13:02 pirate-bot