neve icon indicating copy to clipboard operation
neve copied to clipboard

Price suffix from Neve interfering with price suffix from WooCommerce

Open AndreeaCristinaRadacina opened this issue 1 year ago • 5 comments

Hi there!

I was testing the price suffix from WooCommerce and observed that when I use that and also have prefix/suffix set in the customizer, they will all appear on the card content: image If the user adds a suffix from WooCommerce and a prefix from Neve, there will be typography differences. If he adds both suffix and prefix from Neve and also suffix from Woo ( I don't know why, but maybe someone wants that ), they will all appear.

Let me know what you think!

AndreeaCristinaRadacina avatar Apr 05 '23 14:04 AndreeaCristinaRadacina

Thanks @AndreeaCristinaRadacina, it seems Woo gives users a lot of options for suffix: https://elextensions.com/knowledge-base/add-suffix-woocommerce-product-prices-based-on-user-roles/

@Codeinwp/design-team My initial thought was to override one by the other but I think it might not be the best solution, given users might want to use Neve's option in addition to Woo. What do you think? Just having the same font for both should be good enough?

HardeepAsrani avatar Apr 05 '23 19:04 HardeepAsrani

I think the common font style should be enough, @HardeepAsrani.

As long as we have a separation of concerns, meaning that Neve has its own Prefix/Suffix and Woo has its own Suffix - > users ar free to use any of those, by making an informed decision what would work/look best for them. We don't force or override something.

mghenciu avatar Apr 06 '23 08:04 mghenciu

Sounds good, thank you!

AndreeaCristinaRadacina avatar Apr 06 '23 08:04 AndreeaCristinaRadacina

@HardeepAsrani, I don't think this is an issue. Whatever you add in WooCommerce will replace the {price} magic tag. The current solution in Neve allows you to add a template for the product price. You can add "inc. VAT" in WooCommerce, and in Neve you can have "buy for {price} for a limited time". It should work well.

cristian-ungureanu avatar Apr 10 '23 13:04 cristian-ungureanu

@cristian-ungureanu Yea, it works well but the issue here is with both Woo & Neve prefix having different fonts, can we have same fonts?

HardeepAsrani avatar Apr 10 '23 19:04 HardeepAsrani